On 04/20/10 16:42, Shawn Walker wrote:
On 04/20/10 04:37 AM, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-7062-v2/, fixes
7062 packagemanager BE validation code should be in bootenv.py
This webrev moves libbe related validation code in Package Manager to
bootenv.py.
src/modules/client/bootenv.py:
lines 204-205: simplify to just "return" -- you don't need the
else or None
line 248: s/rc!= 0/rc != 0/
line 531: s/(self)/()/
lines 575-591: might as well make the rest @staticmethod too and
s/self//
Very happy to see these changes.
Cheers,
-Shawn
I have respun the webrev, http://cr.opensolaris.org/~padraig/ips-7062-v3/.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
