On 04/26/10 03:18 AM, Padraig O'Briain wrote:
On 04/24/10 02:54, Shawn Walker wrote:
On 04/23/10 10:11 AM, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-15737-v1/, fixes
15737 Package Manager very slow after doing update

The fix is to not call update_package_list after image update has been
done. The reason for this is that the image update has been done on a
different BE so the status of the packages being displayed in Package
Manager cannot have changed.

That may not necessarily be true in the near future.

You really need to resolve this bug first and then use its value to
determine what action to take:

https://defect.opensolaris.org/bz/show_bug.cgi?id=5907

The only change to the patch you attached to the bug is that I'd
suggest placing that property on the PlanDescription object instead of
the ImageInterface object itself.

Cheers,
-Shawn
I have uploaded webrev for 5907,
http://cr.opensolaris.org/~padraig/ips-5907-v1/.

The new property is on the PlanDescription object..

http://cr.opensolaris.org/~padraig/ips-5907-v1/src/modules/client/api.py.wdiff.html

  line 2728: add the '@property' decorator to this routine and add
             a docstring with wording such as:

        """A boolean value indicating that execution of the plan will
        require a restart of the system to take effect if the target
        image is an existing boot environment."""

This will probably need some correction in the near future, but I don't think you need to worry about it. What you have is good enough for the moment after the changes above, and any future changes will be hidden from API consumers.

Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to