On 05/12/10 12:47 PM, Bart Smaalders wrote:
http://cr.opensolaris.org/~barts/15939/
15939 Need a easy way to format package manifests in a consistent style
15940 Some changes to pkgmogrify would facilitate ON manifest editing
src/man/pkgfmt.1.txt:
lines 13, 16, 25: the capitalisation of the command name seems odd
line 14: s/consistant/consistent/
line 20: s/the/from/
lines 21, 23, 26, 30, : s/formated/formatted/
line 21: s/on the/to/
line 39: 0 Command succeeded.
line 44: add '.' to end
line 848: s/at/at:/
src/man/pkgmogrify.1.txt:
lines 73-75: Suggest replacing with:
-i Ignore include directives in files; only files specified on
the command line (or stdin) are processed.
src/setup.py:
line 22: copyright needs update
src/util/publish/pkgfmt.py:
lines 87-89: reformat for 80 columns?
line 98: Can be simplified to: line[:-1]
line 105: nit: we generally use " instead of ', and this would be
consistent with line 122, etc.
line 122: I'd just use actstr[0] and actstr[-1] instead of *with()
not only to be consistent with 105, etc. but because it's faster
anyway (especially on SPARC) for single character comparisons.
src/util/publish/pkgmogrify.py:
line 391: s/=/ = /
line 457: stray newline?
src/tests:
Some simple tests would be appreciated.
Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
