On Mon, May 17, 2010 at 03:40:18PM -0500, Shawn Walker wrote: > On 05/17/10 03:22 PM, johan...@opensolaris.org wrote: > ... > >I've incorporated these changes into the latest webrev, which is > >available below. Hopefully, this addresses the remainder of your > >concerns. > > > > http://cr.opensolaris.org/~johansen/webrev-6957-3/ > > src/depot.py: > line 552: nit: s/used/provided/ ? trying to figure out some way > to make it not sound like you can only use -d or --file-root > (as opposed to both)
Changed to, "At least one of PKG_REPO, -d, or --file-root must be provided" > src/man/pkg.depotd.1m.txt: > What mdns or dns-sd means is never defined here. Also, should it > be written as mDNS instead of "mdns" ? Also, is there another > man page for see also that might be helpful with this? I've made the corrections that Danek suggested; however, I'm not sure what you'd like me to do about defining mdns or dns-sd. Multicast DNS and DNS Service-Discovery or do you want me to quote from the RFCs for these things? > src/modules/server/depot.py: > line 147: To avoid affecting the class variable, I'd insert > a line above this with: "self.ops_list = self.ops_list[:]". How about "self.ops_list = self.REPO_OPS_MIRROR[:]" on line 145 instead? > src/modules/server/repository.py: > lines 427-429: I think this should be above the self.__reset() block These line numbers don't match anything that I changed in repository.py. Can you clarify this comment? > src/tests: > The only thing you're missing now is a test in cli.t_pkg_depotd to > verify that you can start a depot server with just a file_root and > that everything but /file/ requests are disabled. I'll see what I can do. Thanks, -j _______________________________________________ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
