On 05/18/10 06:11 PM, Richard Lowe wrote:
Brock Pytlik wrote:
t_variant:
Why the change from import p.v as v to from p import v?
Nits:
dependencies.py:
447,453: no empty comment lines please
462, 463 4 space indent please
t_variant.py:
Assuming this should be t_pkgdep.py
Yep, sorry about that
538: extra blank line
empty comment lines: 1225, 1228, 1233, 1236, 1243,1245
t_pkgdep_resolve.py:
39: We usually put from X import Y statements after the other import lines
Bad habits on my part, in all cases. I think I rectified them all:
http://cr.opensolaris.org/~richlowe/pkg_15647-2
I'll fix up the assignee, etc. of #15959 when I close it.
Great. And this LGTM.
Brock
-- Rich
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
