On 05/18/10 06:10 PM, [email protected] wrote:
On Tue, May 18, 2010 at 05:56:13PM -0700, Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-16001-v1/
Bug:
16001 gui test suite broken again
Instead of catching every exception on import, would it be possible to
do something like:
try:
import XXX
except (EnvironmentError, ImportError):
This would catch the cases that might cause the module to fail to
import, but shouldn't catch _everything_. I'm assuming, of course, that
we really don't want to catch everything, but I've been wrong before...
-j
I do think we want to catch everything. I don't really care WHY the gui
tests failed to run this particular time, I just want the rest of the
test suite to drive along after telling me that the gui tests couldn't
be run. For example, in this case it doesn't appear that either an
EnvironmentError or ImportError was raised. Instead, it seems like a
gtk.GtkWarning was raised. I think we've tried finesse approaches
several times now. Since this continues to be an issue, I'm for taking a
sledge hammer to the problem.
Thanks,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
