LGTM.
JR
On 05/24/10 04:29 PM, Padraig O Briain wrote:
I have respun the webrev,
http://cr.opensolaris.org/~padraig/ips-12606-v4/.
I get the text from the button. I have not put it in bold as this is
very awkward to do when adding text to a GtkTextBuffer.
Padraig
On 05/24/10 11:44 AM, John Rice wrote:
Reviewed this offline with Padriag, like it a lot. I understand
Joanie's feedback that it would be nice to gather all the packages
that would fail in one go, but this could take a long time to do so
under the covers and I like this interaction flow. It works very well
if there are only a few packages that fail in a long list.
One comment, bold the Close button text in the Error output to draw
users attention to the line in question and get the text here
directly from the button, in case there are translation issues.
JR
On 05/18/10 11:03 AM, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-12606-v2/, fixes
12606 packagemanager could give a "continue" option
This webrev offers the user the option of continuing to attempt to
remove packages if the removal of one package failed because of
NonLeafPackageException.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
