[email protected] wrote:
> Folks,
> The following code review adds support for UNIX domain sockets as a
> transport option for both the client and depot. This is needed by
> Zones, in order to support a protected local -> global zone transport.
>
> The webrev is here:
>
> http://cr.opensolaris.org/~johansen/webrev-10924/
No documentation? Also, why is "system repo" tied up with support for unix
domain sockets? Is there another RFE being implemented here? If none of
this is public interface, then a doc in the doc directory would be
appreciated. (That can be another changeset, if you're particularly
anxious.)
client.py:
- I'm confused about some of the distinctions made here. Why are origins
which point to unix domain sockets special things called "system repos"
instead of being handled just like another origin?
I'm also confused by --system-repo vs --socket-path. If you're adding
a publisher that's available from a unix domain socket, which one do
you use, and if you use --system-repo, what does it look like?
- line 2566: how is --system-repo different from the other options that
can't be used along with -p? Should --clear-system-repo be here, too?
api_errors.py:
- lines 1309,1317: add spaces before backslashes
t_pkg_image_create.py:
- does sock_path end up being stored under the test's private directory,
or actually in /tmp?
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
