On 06/ 8/10 10:28 AM, Danek Duvall wrote:
http://cr.opensolaris.org/~dduvall/pkg-actstr/has a fix for 16191 quotation marks not properly quoted when actions are converted to strings Unfortunately, we take about a 6.5% speed hit on this, but everything else I tried was worse. If we don't do the additional checks for single or double quotes on lines 235 and 217, we get essentially the original speed (though the benchmark doesn't test the weird quotation cases), but we don't convert something like value='"foo"' correctly. I figure if the speed is really a problem, we can write a conversion function in C.
So I briefly tried using .encode("string_escape") just to see if the performance was much better -- it wasn't. In addition, using that would require additional tweaks, and this seems to work as expected.
I'd say "go with it". Cheers, -Shawn _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
