On Wed, Jun 16, 2010 at 12:29:49PM -0700, Danek Duvall wrote: > [email protected] wrote: > > > http://cr.opensolaris.org/~johansen/webrev-16241/ > > Looks fine to me, aside from one nit: > > transport/exception.py: > > - line 237: I think the right thing here is to return NotImplemented
I fixed this on line 236 by changing the isinstance call to check for TransportStallError instead. We do want to be able to compare objects of different types, but they should never compare as equal. Thanks for catching that! -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
