Is it your intention that I should wrap all lines longer than 80 characters, without splitting string constants, even if the result still has a segment longer than 80 characters?
If so, should I also wrap lines 108 and 310? --chris [email protected] wrote: >> complete webrev: >> http://cr.opensolaris.org/~quenelle/webrev.15623/ > > Hopefully final set of comments, almost all nits: > > Line 151 - Linewrap the "set" action with a continuation character. > Also for some reason here you separated the keywords with commas but > that's not necessary and is inconsistent with the other such set > actions (plus the commas are likely not ignored.) > > Line 169 - Linewrap the "set" action with a continuation character. > > Line 188 - Ditto. > > Line 261 - Ditto. > > Line 287 - Ditto. > > Line 213 - Continuation character missing after the "summary ". _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
