On Tue, Jun 29, 2010 at 06:21:22PM -0700, Edward Pilatowicz wrote: > On Tue, Jun 29, 2010 at 10:21:43AM -0700, Gary Pennington wrote: > > Hi, > > > > Small/Quick code review please. Anyone from the zones team who knows the > > context of http://sac.sfbay.sun.com/PSARC/2010/156/mail would be ideal. > > > > webrev: > > > > http://cr.opensolaris.org/~garypen/gate/ > > > > workspace: > > > > /builds/garypen/HG/6939693-pkg/gate > > > > hey gary, > > so, support.c doesn't do anything other than check for inherit-pkg-dir > entries. hence it seems best to just remove the whole program rather > than leave it to do nothing. :) >
Hi Ed, I had previously looked into the usage of this bit of code and it seems to be used as part of the "under-pinning" of the zones infrastructure: e.g: ./sn1/zone/config.xml: <verify_cfg>/usr/lib/brand/ipkg/support verify</verify_c fg> ./ipkg/zone/config.xml: <verify_cfg>/usr/lib/brand/ipkg/support verify</verify_c fg> ./labeled/zone/config.xml: <verify_cfg>/usr/lib/brand/ipkg/support verify</ verify_cfg> bash-4.0$ This is a bit of the code that I'm unfamiliar with and, since I'm making extensive changes anyway, I decided to be conservative and keep this in place. I'd rather treat removal of it as a separate fix, since the change I have in 6939693 are tested and approved to integrate and it's important to get these changes back. If you do think we should remove the code, then I'll file another bug to cover that change and do that separately. Gary > > I also have a question... > > > > I don't want to putback this change until after I've putback the main change > > for 6939693 to ON. How can I advise people that if they want zones > > to work properly after 6939693, they will need to update the pkg code? > > > > Traditionally, we've solved that kind of problem in the past with an > > update-<whatever> script that you can run to bring your system up to date? > > Does such a script exist, update-pkg, and can I reference it in a > > Heads-Up message? > > > > i'd actually recommend putting this change back as early as possible > before the ON change because this change won't actually break anything, > where as if the ON change goes back first, the existing support.c > program will be broken. > > wrt update- scripts, that mechanism doesn't really make sense in the > post-ips world. post-ips people use image-update so they update all > their bits in sync. the only people who could get into trouble are > those using onu to update just the ON consolidation. for those, you > could send out a heads up saying something like: > if you onu to ON bits with my fix for 6939693, then you must be > running pkg bits from at least snv_XXX, otherwise zones will be > broken. > > ed -- Gary Pennington Solaris Core OS Oracle Corp [email protected] _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
