On 07/20/10 09:51 PM, Shawn Walker wrote:
On 07/20/10 01:06 AM, Padraig O Briain wrote:
On 07/19/10 06:27 PM, Shawn Walker wrote:
On 07/19/10 04:58 AM, Padraig O Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-16579-v1/, fixes
16579 PackageManager gets different results for installed and
non-installed package
This change avoids calling API info with an empty list when getting a
list of packages from search results. The behavior of the info() call
had changed when passsed an empty list in revision 1970.
Please hold off on a putback for this until we can determine what the
change was.
I don't recall intentionally changing behaviour of an empty list, but
it also isn't clear whether the previous behaviour was correct.
If you can add your comments to the bug about what the previous
behaviour was (with a precise before and after comparison of output),
that would be helpful.
I think that this change is worth making even if you decide to change
the behavior of info() back to the original.
I have added a test program to the bug 16579 to show the change in
behavior.
Indeed, drive on. The change to info() was intentional now that I
understand what you're seeeing. The change was to make info()'s
behaviour consistent whether local was True or False so that users
would get more consistent results.
In addition, info() now uses get_pkg_list() as a backend, so handles
renames, etc.
Yes please.
I have logged https://defect.opensolaris.org/bz/show_bug.cgi?id=16608.
Padraig
Which reminds me that I can expose variant filtering for info() as
well now if that's useful to you. (Variant filtering meaning info()
wouldn't return SPARC packages for an x86 image unless you
specifically requested it.)
Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
