Brock,
On Fri, Jul 23, 2010 at 07:24:44PM -0700, Brock Pytlik wrote:
> Webrev:
> http://cr.opensolaris.org/~bpytlik/ips-11611-v2/
I'm just looking at the transport bits for now:
transport/repo.py:
- You'll need to merge with my changeset that fixes the error message
problem with publication operations that return a 400.
- Lines 584-587: The transport allows you to provide a filobject
instead of the data. The 'sz' variable is also unused. There are
two options here. You can either supply the path, and have the
transport open the file. I've implemented that functionality, but
not exposed it to send_data(). Alternatively, you can open the file
and pass the fileobject as an argument to _post_url() using the
data_fobj kwarg.
transport/transport.py:
- lines 2118 and 2309: Since not all repositories will support these
operations intitially, it looks like you need to introduce the
__gen_publication_origin equivlanet of __gen_origins_byversion.
Perhaps, something like __gen_puborigin_byversion. Essentially,
this needs to look at the publication origin and see if it supports
the requested version. If not, the operation should return an
exception, like the other callers of __gen_origins_byversions do.
depot.py:
- Have you verified that the HTTP responses for the operations that
you're adding contain cache control headers? There are a couple of
corner cases for returning these.
- lines 985 and 986: Shouldn't this be "0" for both assignments?
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
