Hi all, I've got another pkglint webrev here that I'd really appreciate code review comments on please?
http://cr.opensolaris.org/~timf/pkglint-webrev-2 Changes since the last webrev are: * more unit tests * added check for UTF-8 encoded manifests * better log output & 'pkglint -L' output * cleaned up dependency & legacy checks * lint messages are sent to stderr, not stdout * better wording in the man page Other than addressing code review comments, I don't intend to make any changes to this wad before putback. [ figured my last pkglint webrev may have suffered from the Osbourne effect, in that I sent it out *and* promised an update, hence lack of code review comments for that one :-) ] There's two features not in pkglint at the moment that I'm planning to address post-putback: * support for exclude dependencies We don't use these much at the moment, so figured they were a low priority * support for multiple publishers per client lint-image. We can only configure one publisher per lint or reference image at the moment. I'd like to be able to lint, eg. an aggregated view of an on-nightly and opensolaris.org client image, choosing the right packages to lint according to the publisher search order: I couldn't see an obvious way to get this from the client api at the moment (other than bypassing the api, and using ImagePlan.match_user_fmris(..) directly) - is this something that we should have in the client api? cheers, tim _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
