On 08/17/10 06:22 AM, Jerry Jelinek wrote:
On 08/16/10 11:51, Susan Kamm-Worrell wrote:
I've got a fix for
16805 mount of ipkg zone in alternate root fails
I added an extra parameter to be passed to the ipkg zone prestate and
poststate hooks which is the alternate root of a zone in a mounted
boot environment. The alternate root is used to find the
correct global_zone_boot_environment for mounting the zone's root.
pkg webrev at:
http://cr.opensolaris.org/~skamm/webrev.16805
Susan,
This looks good to me. I just had one nit.
src/brand/common.ksh
148-149 I think this comment is misleading since it
discusses the uncommon case but not the common one.
Can you add to the comment explaining the normal
behavior. Also, can you move the comment from
145-147 down to the code it describes (line 167).
Thanks,
Jerry
Jerry,
Thanks for the review.
Here's the new comment at the head of get_current_gzbe():
#
# If there is no alternate root (normal case) then set the
# global zone boot environment by finding the boot environment
# that is active now.
# If a zone exists in a boot environment mounted on an
alternate root,
# then find the boot environment where the alternate root is
mounted.
#
Does this explain it better?
I also moved the other comment down where you suggested.
Thanks,
Susan
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
