On Tue, Aug 24, 2010 at 02:47:16PM -0700, Shawn Walker wrote: > On 08/23/10 10:21 PM, [email protected] wrote: > >Folks, > >Over time the pkg(5) source code has sprouted a number of different, > >independent file locking routines. This leads to a maintenance hassle > >for the code, as any change to the locking code generates updates in > >various places, if any bugs are found. This change makes the code > >common, but customizable, so differnet modules can implement different > >behaviors. I fixed a couple of additional locking bugs that were > >discovered along the way. > > > > http://cr.opensolaris.org/~johansen/webrev-14615/ > > src/modules/client/image.py: > line 393: debug code?
Yes, removed. Thanks > src/modules/lockfile.py: > lines 68-72: why are these protected instead of private? Mostly so that any class that extends LockFile can make use of the attributes without a lot of hassle. > line 77: s/ = / = / Fixed, thanks. > line 87: why not drop the else: and simply return? Changed. > line 175: nit: insert newline here Added. > line 177: docstring? Added, but I'm not sure how useful this is. > src/modules/misc.py: > line 815: nit: insert newline here Added. > Otherwise, seems right to me. Thanks for taking a look at this. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
