On 08/26/10 02:49 PM, Tim Foster wrote:
On Thu, 2010-08-26 at 14:43 -0700, Shawn Walker wrote:
On 08/26/10 02:40 PM, Tim Foster wrote:
Hi Shawn,
On Thu, 2010-08-26 at 11:00 -0700, Shawn Walker wrote:
webrev:
http://cr.opensolaris.org/~swalker/pkg-11740/
pkg.lint.engine is a client api user so I think it needs to get a new
CLIENT_API_VERSION update along with this change (looks like my putback
yesterday has an out of date version too :-/ )
Otherwise, the change looks good I think.
Thanks; so we don't have any unit tests for lint in our gate then? If
not, can we open a bug to get some?
Yep, there's unit tests there, but that they're not failing makes me
wonder whether the engine is doing the right thing.
./src/modules/lint/engine.py on line 561 is creating images using it's
own CLIENT_API_VERSION string. If an image already exists, on line 561
it uses pkg.client.api.CURRENT_API_VERSION to obtain an api_inst.
Is this incorrect usage?
Yes. Clients are supposed to supply the ImageInterface with the version
of the pkg.client.api *they* understand. The logic is that if if a
client specifies a version that's no longer compatible with the current
API that a version exception will be raised to prevent a client from
failing somewhere during execution instead of at API init.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
