On 09/ 6/10 05:38 PM, Tim Foster wrote:
On Sat, 2010-09-04 at 23:20 -0700, Shawn Walker wrote:
Greetings,

The following webrev contains fixes for the following issues:

    16982 depot should be more cooperative about indexing during startup
    16941 pkg.depotd(1m) should not imply consumers require it for
repository access
    16949 references to default_publisher should be removed

webrev:
http://cr.opensolaris.org/~swalker/pkg-16982/

src/man/pkg.depotd.1m.txt line 39 has a missing space "runningunder"

src/modules/server/depot.py line 320 - can you explain why ignoring
Queue.Full exceptions is ok here?

It could log a warning that it was unable to queue indexing, but otherwise, simply because a failure here isn't deemed important.

I was expecting this to be one of the places where we'd raise an
exception to eventually to log the fact that the index can't be updated
(the others being unable to grab the index lock, or hitting general
indexer exceptions I guess)

That generally happens anyway, so I'll just change it to log the fact that indexing couldn't be started. I'm not expecting that to ever happen due to where indexing is queued, but too man things happen that aren't supposed to :P

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to