On Mon, Sep 27, 2010 at 04:51:18PM -0700, Shawn Walker wrote:
> Greetings,
> 
> The following webrev contains fixes for the following issues:
> 
>   17055 image configuration should use pkg.config classes
>   8785 ImageConfig.read() should reset itself completely before reading
>   16109 imageconfig shouldn't store the publisher sort order in two places
>   17117 image_create with force=true leaves behind previous image data
> 
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-config/

Only one question so far...

image.py:

  - line 542:  Is the path.exists() check necessary?  It looks like you
    could skip it and just catch the exception for ENOENT if listdir()
    fails.

-j 
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to