On 10/11/10 03:59, Darren J Moffat wrote:
On 08/10/2010 21:43, Bart Smaalders wrote:
We've been making do with a non-productized merge command
in the packaging gate; it's now time to finish this piece of
functionality.
Yeah!
> -s variant_value,uri
This looks very strange in the way you run the command.
I would much rather it wasn't just the variant_value,uri but
that it was variant=value,uri if that really has to be passed
as a single option. Better yet would be a syntax that didn't require
using a comma separation at all.
Given this is not likely to be something run from the CLI frequently
why not have it take input from a description file instead, for example:
variant debug.osnet=false
repository file:///mybuild/packages/sparc/nightly-nd/repo.redist
variant debug.osnet=true
repository file:///mybuild/packages/sparc/nightly/repo.redist
target file:///mybuild/packages/sparc/merge/repo.redist
fmri consolidation/osnet/osnet-incorporation
This might also allow for doing all of the following example in
a single description file instead of having to call multiple times.
There is an inherent pairing that I'm seeking to make clear; passing
in both variant value and server supplying that value as one
argument is one way of doing that. There are others, of course.
I really am not interested in interfaces that require files w/ a new
syntax; invoking these from make involves echoing commands into a file
and it just gets ugly.
The merge step is designed to handle a single variant at a time.
The complications involved in merging multiple variants at once
seems unneeded, particularly since it reduces available parallelism
and makes things much more difficult to understand.
Other than how we're passing the command line arguments, is the
functionality sufficient?
- Bart
--
Bart Smaalders Solaris Kernel Performance
[email protected] http://blogs.sun.com/barts
"You will contribute more with mercurial than with thunderbird."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
