On 10/31/10 09:20 PM, Tim Foster wrote:
hi there,
I've some changes here for 'pkg history' that I'd appreciate a review of
please?
http://cr.opensolaris.org/~timf/history-be-webrev/
3419 history command -- ability to specify dates or date ranges desired
17012 pkg history should include boot environment or snapshot information
17013 pkg history subcommand should display boot environment and snapshot
information
17222 pkg history could use a -o option
Other than the unit tests I've added, I've manually tested the gathering
of boot environment, new boot environment, and snapshot information for
pkg operations.
Comments would be most welcome,
src/doc/history.txt:
general: If you wouldn't mind replacing "swalker" with "username"
everywhere, that'd be great. I never meant to have mine there.
line 85: Is this the *name* of the new be? Same question applies
to man/pkg.1.txt line 786.
line 160: nit: always place two spaces between sentences
src/client.py:
line 221: why not -d for date instead of -e? or are option values
sometimes not dates? I have no particular preference here, just
wondering what alternatives were considered.
line 3967: no '' around %s?
Otherwise, this looks very thorough. Do you have any sample output?
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
