On 11/30/10 01:33 AM, Shawn Walker wrote:
On 11/29/10 02:18 AM, Saurabh Vyas wrote:
Hi All,
Please review this fix and let me know your comments.
Bug-id : 17445 broken string in pkg set-publisher error message
webrev : http://cr.opensolaris.org/~saurabhv/Bug-17445-1/
With my fix, the o/p is :
No, that's not quite right. It should be like this I think:
diff -r 6a8649974d4f src/client.py
--- a/src/client.py Fri Nov 19 17:35:05 2010 -0800
+++ b/src/client.py Mon Nov 29 12:01:56 2010 -0800
@@ -3028,8 +3028,7 @@
if rval != EXIT_OK:
if rmsg:
- error(rmsg, cmd="set-publisher")
- failed.append((prefix, msg))
+ failed.append((prefix, rmsg))
continue
first = True
Try that, and then see what output you get.
Thanks Shawn,
This too works as expected, I have updated the webrev (webrev :
http://cr.opensolaris.org/~saurabhv/Bug-17445-2).
Please verify the same & let me know if this good to be integrated.
BTW the o/p after this fix is :
v...@solaris:~$ pkg set-publisher -p
file:///net/onnv-x86-build/builds/sv204098/onnv-latest/packages/i386/nightly-nd/repo.redist/
pkg set-publisher: failed to add or update one or more publishers
on-nightly:
Could not operate on /var/pkg/lock
because of insufficient permissions. Please try the command again using
pfexec
or otherwise increase your privileges.
I also had a test run, all tests finished successful.
Thanks,
~Saurabh
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
