LGTM, and thank you.

I'll update the OS/Net usr/src/pkg/Makefile to use -d when this gets
onto build machines.

--Mark

On 02/ 4/11 02:19 PM, Bart Smaalders wrote:
> It being Friday, I coded a simple fix for a simple request:
> 
> http://cr.opensolaris.org/~barts/17815/
> 
> 17815 pkgfmt should be more verbose about formatting problems
> 
> As requested in the bug report, the incorrect version is used
> as the right side of the diff so that the error is seen as a deviation.
> 
> Sample output:
> 
> : barts@cyber[21]; /home/barts/ws/pkg-clone/src/util/publish/pkgfmt.py 
> -d test.mf
> ---
> +++
> @@ -301,11 +301,11 @@
>   dir path=lib/svc/manifest/system/device group=sys mode=0755 owner=root
>   dir path=lib/svc/manifest/system/filesystem group=sys mode=0755 owner=root
>   dir path=lib/svc/manifest/system/security group=sys mode=0755 owner=root
> -dir path=lib/svc/manifest/system/svc group=sys mode=0755 owner=root
> +dir path=lib/svc/manifest/system/svc group=sys owner=root mode=0755
>   dir path=lib/svc/method group=bin mode=0755 owner=root
>   dir path=lib/svc/monitor group=bin mode=0755 owner=root
>   dir path=lib/svc/seed group=bin mode=0755 owner=root
> -dir path=lib/svc/share group=bin mode=0755 owner=root
> +dir path=lib/svc/share group=bin  mode=0755 owner=root
>   dir path=mnt group=sys mode=0755 owner=root
>   dir path=opt group=sys mode=0755 owner=root
>   dir path=proc group=root mode=0555 owner=root
> : barts@cyber[22];
> 

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to