On Mar 14, 2011, at 4:51 PM, Danek Duvall <[email protected]> wrote:

> Emit actions seem to cause some bogus output.  Here's the bug:
> 
>    18005 pkgmogrify emits bogus [] actions when pkg attributes are transformed
>    https://defect.opensolaris.org/bz/show_bug.cgi?id=18005
> 
> Here's the fix:
> 
>    --- a/src/util/publish/pkgmogrify.py
>    +++ b/src/util/publish/pkgmogrify.py
>    @@ -544,7 +544,8 @@ def apply_transforms(action, pkg_attrs, 
>                     if not isinstance(act, basestring):
>                             c, al = apply_transforms(act, pkg_attrs, verbose,
>                                 act_filename, act_lineno)
>    -                        comments.append(c)
>    +                        if c:
>    +                                comments.append(c)
>                             newnewactions += [a for a in al if a is not None]
>                     else:
>                             newnewactions.append(act)
> 

LGTM,

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to