On 03/23/11 00:47, Brock Pytlik wrote:
Greetings all,

Webrev:
http://cr.opensolaris.org/~bpytlik/ips-18045-v1/

Bug:
18045 pkgdepend resolve fails to recognize unvarianted dependencies

Tim ran this change over ON for me with his ON fixes and this fixes all
of the python errors he was seeing. We'd like for this to make 162 if
possible so his changes aren't pushed out further than they have to be.

Thanks,

src/modules/publish/dependencies.py:

1112: add distro_vars to doc string at beginning of function.

src/modules/variant.py:

163 & 164 can ben more efficiently combined:

   self.setdefault(name, set([])).update(var[name])

Otherwise, lgtm.

- Bart






--
Bart Smaalders                  Solaris Kernel Performance
[email protected]       http://blogs.sun.com/barts
"You will contribute more with Mercurial than with Thunderbird."
"Civilization advances by extending the number of important
 operations which we can perform without thinking about them."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to