Sure you know this but the api version will need to be bumped when you merge with 18047.

actions/file.py::
460: extra new line

pkgplan.py:
line 421: why doesn't image.salvage take care of appending the path and spath to imageplan's _salvaged instead of pkgplan reaching through the image? Also, why is it using _salvaged instead of salvaged?

Other than that, lgtm.
Brock


On 04/ 1/11 11:54 AM, Shawn Walker wrote:
On 03/25/11 10:42 AM, Shawn Walker wrote:
Greetings,

The following webrev contains fixes for the following issues:

3679 modified preserve=true files should be backed up during uninstall
18083 pkgplan should not print environment failure messages during
operations
18084 api should not log salvaged item messages during package
operations

webrev:
http://cr.opensolaris.org/~swalker/pkg-salvage/

Anyone?

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to