On 04/ 7/11 07:06 PM, Tim Foster wrote:
Hi Brock,
On Thu, 2011-04-07 at 12:14 -0700, Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-18130-v1/
Bug:
18130 pkgdepend doesn't simplify variants where it should
I had a look at this, and I think it's ok.
Thanks!
One useful thing would be to file an RFE to write more tests for
variants.py, especially for __calc_simple() to make maintenance a little
less scary here - the t_pkg_dep tests are good too - but more
coarse-grained.
I definitely agree. I've filed bug 18135 to address this issue.
As mentioned on IRC, I did a 'make gendeps' on an i386 onnv-clone with
these changes, which looked good.
Thanks for checking that for me!
Brock
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
