On 04/11/11 01:36 PM, Brock Pytlik wrote:
On 04/10/11 06:57 PM, Tim Foster wrote:
[snip]
Brock's original question (which I answered offline) led me to
reconsider the way this was being fixed, and I've come up with
http://cr.opensolaris.org/~timf/pkglint-file-move-webrev-1
Danek saw a first-pass of the changes, and suggested a better construct
for the check that's now on line 151 of pkglint_action.py, as part of
some related work in the userland pkglint plugin - thanks Danek.
Comments welcome?
pkglint_action:
line 495, 496: aren't these lines over-indented?
Complete nit: line 135: I find the phrase "with any for which" makes
my head want to explode... and I don't even know why.
Perhaps:
"Construct the set of fmris presented for linting so that their
predecessors can be skipped when seeding the reference dictionary"?
Forgot one other thing, the two for loops could be combined into one if
you used itertools.chain to put the two things your looping over into
one big iterable. I don't know if that's better/easier to read or not.
Your call :)
Brock
lgtm,
Brock
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
