On Wed, Apr 20, 2011 at 02:35:26PM -0700, Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following issues: > > 18193 transport can traceback for packages that belong to a publisher > not in configuration > 18195 transport adds all publisher caches from multi-publisher file > repositories > > webrev: > http://cr.opensolaris.org/~swalker/pkg-18193/
These changes look good. In most of the transport module, the majority of the exceptions raised are subclasses of TransportError (or TransportException), but the new code here is in the api_error module instead. I don't have a strong objection to this, but I wondered if it would make more sense to have a TransportError equivalent of NoPublisherRepositories? -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
