* Gary Pennington ([email protected]) wrote: > On 05/ 4/11 07:01 PM, Shawn Walker wrote: > >On 05/ 4/11 10:46 AM, Glenn Lagasse wrote: > >>Hi, > >> > >>I'd like to get a code review for a very simple fix to the zone install > >>script. With the integration of 7034756 we should be installing beadm > >>inside of non-global zones at installation time. > >> > >>src/brand/pkgcreatezone: > >> > >>diff -r 39ae727e734e src/brand/pkgcreatezone > >>--- a/src/brand/pkgcreatezone Wed May 04 16:32:30 2011 +0100 > >>+++ b/src/brand/pkgcreatezone Wed May 04 10:40:34 2011 -0700 > >>@@ -502,7 +502,8 @@ > >> pkg:///compress/gzip > >> pkg:///compress/zip > >> pkg:///compress/unzip > >>- pkg:///package/pkg" > >>+ pkg:///package/pkg > >>+ pkg:///install/beadm" > >> > >> # > >> # Get some diagnostic tools, truss, dtrace, etc. > > > >Out of curiosity, do you know why this list of packages for zones > >is handled through the brand scripts instead of package > >dependencies tagged with a zone variant? > > > >-Shawn > >_______________________________________________ > >pkg-discuss mailing list > >[email protected] > >http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > > Looks good to me.
Great! Thanks Gary. Now, I would like to get this into the pkg gate for build 166 (which is the build 7034756 integrated into). My questions are a) when would be the best time to integrate (integrating into say 165 wouldn't be disastrous, beadm in a non-global zone would just exit with a message saying it doesn't run in non-global zones but I'd like to avoid as much confusion as possible and b) can I get a volunteer with commit rights to the pkg repo that I can hand the diff off to please? Thanks! -- Glenn _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
