On 05/ 5/11 10:36 AM, Shawn Walker wrote:
Greetings,
The following webrev contains a fix for the following issue:
17558 pkg configuration can't be updated if a publisher source points
to down NFS server
webrev:
http://cr.opensolaris.org/~swalker/pkg-nfs/
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
I don't have any objections to these changes, but I struggled to
understand the changees. I think __set_caches needs a comment or
documentation. I can't tell if the variable means that caches should be
set, have been set, will be set, nor do I have an intuition for what
"setting a cache" means. Perhaps __caches_populated or __caches_built or
__caches_filled would be a more descriptive name.
Other than that, LGTM.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
