On 05/ 5/11 04:45 PM, Danek Duvall wrote:
Shawn Walker wrote:

On 05/ 5/11 04:28 PM, Danek Duvall wrote:
Shawn Walker wrote:

   http://cr.opensolaris.org/~swalker/pkg-defriend-2/

   - Given that we're removing 13 character columns from the output, perhaps
     we can adjust the widths of the existing columns?  Perhaps another ten
     to the package name and the remaining three to the version?

The width specified here isn't a maximum; it's a minimum, so I don't
know how much changing it actually matters since many of our package
names are quite long.  However, I'll see if increasing it makes any
effective difference.

If you use my suggested numbers, then it'll give a minimum of 55 characters
to the package name before the columns get out of whack, and 18 to the
version, which means that some number of packages will no longer mess up
the columns.  In the solaris repo at build 163, the longest package name we
have is 53 characters, so everything should line up nicely as long as it's
the primary repo.

I've adjusted all of the widths, and yes, your numbers (with a bit of tweaking for some of the output formats) work better I think.

Our longest package name is actually 69 characters (counting this unbundled):

developer/solaris-studio-express/solaris-studio-express-incorporation

Ignoring that, it's this one at 52 characters:

gnome/speech/gnome-speech/driver/gnome-speech-espeak

Since our upcoming version scheme appears to use 19 or 20, I've tweaked everything a bit.

I'll send out a new webrev shortly after I've rewhacked all of the unit tests :/

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to