On 05/ 6/11 02:02 PM, Danek Duvall wrote:
This is a fix for

     18271 setup.py can die if "col" is None
     https://defect.opensolaris.org/bz/show_bug.cgi?id=18271

     --- a/src/setup.py
     +++ b/src/setup.py
     @@ -720,8 +720,8 @@ def syntax_check(filename):

                              # Assume it's a tuple of (filename, lineno, col, 
code)
                              fname, line, col, code = err
     -                        res += "line %d, column %d, in %s:\n%s" % (line, 
col,
     -                            fname, code)
     +                        res += "line %d, column %s, in %s:\n%s" % (line,
     +                            col or "unknown", fname, code)

                      raise DistutilsError(res)

So if the column comes across as None for whatever reason (I don't
understand why it happens), then simply you'll see "column unknown" instead
of a stacktrace, or "column None" or some bogus number.

+1 (assuming that col is never 0, not that it matters much if it was).

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to