Thanks Padraig pylint changes made, tested and put back.

JR

On 17/05/2011 11:06, Padraig O Briain wrote:
This looks good to me except for some pylint warnings about lines too long in misc.py and repository.py.

Padraig

On 05/17/11 10:20 AM, John Rice wrote:
Here's a minor update to the webrev, tweaks to the wording of the log message and changes the command in the message to take account of the user running from a local image.

webrev: http://cr.opensolaris.org/~jmr/pm_18258_add_pub_crash_may17_1015am/
18258 Add publisher crashes in package manager

JR

On 16/05/2011 17:49, John Rice wrote:
On 16/05/2011 17:10, Shawn Walker wrote:
On 05/16/11 08:25 AM, John Rice wrote:
Hi - this is a webrev to fix adding publishers in PM which was broken
with recent interface changes to publisher. We are also checking for the
addtion of multiple pubs from a single origin uri, adding one of them
and logging the fact that PM can only add one publisher per origin at
this time.

webrev: http://cr.opensolaris.org/~jmr/pm_18258_add_pub_crash_may16_3pm/
18258 Add publisher crashes in package manager

To reiterate, this isn't a recent change. Multiple publishers form a single origin has been possible since August of 2010. A flag day went out about this functionality change (it was part of the repository on-disk format change).
Yep I am aware of that I was refering to the recent change in the Publisher constructor, apologies if this wasn't clear.

JR

Note: I've logged a separate bug as logging when running against a local
repo (-R option) appears to be broken:
18351 - Logging broken with local repository

Isn't -R for specifying an image path, not a repository path?
Absolutely, my language skills are failing me today.

Cheers,
JR

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to