On Mon, 2011-05-23 at 20:21 -0500, Mike Gerdts wrote:
> On Tue 24 May 2011 at 12:49PM, Tim Foster wrote:
> > http://cr.opensolaris.org/~timf/zones-fix-webrev
Thanks for taking a look Mike, I mostly agree with your comments on
shell style and will see if I can clean those up.
cheers,
tim
> common.ksh:
>
> - Please only create new upper-case variables if they are environment
> variables.
> - Use typeset to declare variables in functions so that they don't
> create/clobber variables in the global scope.
> - Do not use deprecated features of ksh, such as [ ]
>
> typeset sync=
> [[ $1 == async ]] && sync=-s
>
> I guess I missed some other reviews where I should have spoken up too.
> This is not related to this change, but in general, please declare
> ksh functions as:
>
> function dostuff {
> }
>
> Rather than
>
> dostuff() {
> }
>
> This helps debugging of ksh93 greatly because line numbers referenced in
> ksh error messages actually refer to the line numbers in scripts. This
> is critical for proper functioning of the backtrace function in
> /usr/lib/brand/shared/common.ksh.
>
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
