On Tue, 2011-05-24 at 19:36 -0700, Brock Pytlik wrote:
> On 05/20/11 16:19, Brock Pytlik wrote:
> Updated Webrev:
> http://cr.opensolaris.org/~bpytlik/ips-16271-v2/
> This includes the changes Tim suggested. The only major code changes are
> in dependencies.py, which has a new exception, BadDependencyFmri, and
> t_pkgdep_resolve which has a test for bad fmris in depend actions.
Thanks for making those changes - this looks good to me.
Only one other nit, sorry for not spotting this earlier:
src/tests/cli/t_pkgdep_resolve.py
src/tests/cli/t_pkgdep.py
src/modules/publish/dependencies.py
have some changes where there's extra spaces at the end of the line.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
