Brock Pytlik wrote:
> http://cr.opensolaris.org/~bpytlik/ips-18441-v2/
I've looked over the bits related to the comments I made before, as I
didn't want to do a complete re-review.
One thing I completely forgot about before is that the IFO column in pkg
list can now have its F filled in.
pkg.1.txt:
- line 645: it doesn't change the version of the package installed on the
system, though, does it?
- line 648: no need for two blank lines.
- line 1244: might be useful to have a second line showing the output of
"pkg freeze" after this.
- line 1249: This is supposed to have output, no?
- line 1251: I don't know that this demonstrates anything interesting.
client.py:
- line 2250ff: I'd use "NAME", "VERSION", and "DATE"; our column headers
are generally one-word, and where they're not, it's probably a bug.
- line 2257ff: This is all to not print the build version, right?
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
