On 06/07/11 09:45, Danek Duvall wrote:
Shawn Walker wrote:

Greetings,

The following webrev contains a fix for the following issue:

   8682 stored absolute paths to keys and certs break image root model

webrev:
   http://cr.opensolaris.org/~swalker/pkg-8682/

image.py:

   - line 605: perhaps we could chmod?

Sure.

   - line 607: does copyfile create ssl_dir if necessary?

No, but this is /var/pkg/ssl and the image code attempts to ensure this exists at every point configuration is changed. But it wouldn't hurt to deal with that case here if so desired.

   - line 612: where would the EEXIST come from?

No idea; deleted.

This changes pkg(5) to automatically store SSL Certificates and Keys in
$IMGDIR/ssl (e.g. /var/pkg/ssl).  It also fixes the API so that when
using packaging clients with an alternate image root (e.g. pkg -R /mnt
...) SSL operations work as expected and the Cert and Key from the
alternate root is used.

That is, the paths to the key and cert are always relative to the image
root, right?  This will be a flag-day, though hopefully one with very
limited impact.

No; the paths are always stored as absolute, but then made relative to the image root on load. So I don't see how this would be a flag day.

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to