On 07/06/11 20:03, Brock Pytlik wrote:
On 07/ 6/11 09:06 AM, Shawn Walker wrote:
On 07/01/11 14:48, Brock Pytlik wrote:
On 07/ 1/11 12:03 PM, Shawn Walker wrote:
Greetings,

The following webrev contains changes for the following items:

18625 new disk space information needs improved formatting, wording
18626 disk space computation doesn't account for cache or filesystem
overhead
18647 pkg(1) planning output could be improved

webrev:
https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-space-1/webrev/


See attached text file for detailed commentary of changes.

-Shawn


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
[snip]

One more thought based on something I saw tonight...
I think it'd be worthwhile to force the units of space available and
space needed to be the same.

Instead of:
Additional filesystem space needed: 498.15 MB
Filesystem space available: 369.33 GB

I think this would be better as:
Additional filesystem space needed: 0.50 GB
Filesystem space available: 369.33 GB

Thoughts?

The user will often have free space measured in megabytes, but if we're installing something that is only a few megabytes or less, rounding will make the number 0 or very close to it.

So in your example above, for a single package, they might see 0.0X GB which is not meaningful.

We could simply always display the number in megabytes, but that has downsides too, especially if you run this on something with terabytes or exabytes of available disk space :-)

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to