Shawn Walker wrote:
> https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-validate-1-2/webrev/
generic.py:
- line 1137: why not a try/except here? Just not in the fast path?
imageplan.py:
- line 2983: Why wedge this into ActionExecutionError? Wouldn't a new
SymlinkLoopError be better? That way we can use it in other parts of
the code that might run into the same problem.
- line 2985: The link needn't target itself; only be part of a loop,
which might be much longer than a single path. (I don't think you need
to add tests for this, but the error text could be broader.)
- line 2988: will simply removing the link work, or would you have to run
pkg fix first (assuming the path in question isn't supposed to be
changing in this plan)?
t_pkg_install.py:
- Does pkg fix properly remove a link targeting itself and replace it
with whatever should be there?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
