On 07/26/11 16:49, Danek Duvall wrote:
Here's an updated webrev, taking into account comments presented here and
offline. The biggest change is due to a comment by Shawn that performance
might suffer if we're always building the attribute dictionaries. I did
some tests and saw as much as a 20% hit in some cases. This should reduce
that back down to negligible.
https://cr.opensolaris.org/action/browse/pkg/dduvall/human-version-1-2/human-version-1-2/
src/client.py:
line 3041: Is this trying to account for a case where the package
creator specified a human-version that was identical so we don't want to
bother formatting differently?
src/modules/client/api.py:
line 2660: minor nit, but can you put 'collect_attrs' after 'cats'?
these are all keyword arguments and this is an incompatible change
anyway. (Update the docstring too; thanks!)
line 3084: I wouldn't bother sorting the values for the attribute, I
think having them returned in the order they were specified is actually
just fine.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
