On 08/09/11 17:39, Brock Pytlik wrote:
On 08/09/11 14:52, Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issue:
18791 pkgfmt cannot cope with nested quotes
webrev:
https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-18791/webrev/
-Shawn
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Is there any danger of this change breaking existing manifests? Mostly
No.
I'm thinking of ones with a single \ indicating a new line like those in
the test suite. If there is, it's probably worth at least a heads up
(and a check to make sure this won't break existing builds). If there's
no danger, then how about leaving a couple as single \'s so that we test
that path too.
The '\' -> '\\' was a bug in the test data. The single '\' was never
seen by our parser, it instead caused Python to omit the embedded newline.
$ python -d
Python 2.6.4 (r264:75706, Jul 20 2011, 20:06:02) [C] on sunos5
Type "help", "copyright", "credits" or "license" for more information.
>>> print """\
... foo \
... bar \\
... zoo"""
foo bar \
zoo
-Shawn
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
