On 08/23/11 11:59, Saurabh Vyas wrote:
On 08/23/11 05:15, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/4315-v1
Bug:
4315 'pkg contents -m' for multiple packages sorts, when it shouldn't
Hi Brock,
In general this LGTM, only one question :
- in the setUp() you have added
78 self.plist = self.pkgsend_bulk(self.rurl, (self.bronze10,
not sure where we are using the 'plist'.
Please if you can clarify.
Apologies I missed the new test case added by you (test_bug_4315 ).
This seems fine now.
These changes LGTM.
~Saurabh
Thanks,
~Saurabh
Thanks,
Brock
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
--
Sun, an Oracle company
Sun, an Oracle Company
Saurabh Vyas
Solaris Install Group,
Revenue Product Engineering (RPE), Systems
|Bangalore |
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
