Hi Bart,

src/util/publish/transforms/documentation:

34:
Anchor $ could be missing.

src/util/publish/transforms/locale:

28:
Is this facet useful?
Directories like "C" or "common" never exist in "locale"?
The other transform deletes facet.locale.C but not delete this.
I understand this facet can select/unselect locale directory itself, but
it seems to me that selecting/unselecting per-language or per-locale
files/subdirs is sufficient.

anyway, 28:
hadlink does not make sense here?

30:
Seems better to be more specific to locale name pattern like

<transform dir file link hardlink \
   path=.+/locale/([a-z]{2,3}(_[A-Z]{2,3})?)([/.@].+)?$ -> \
   default facet.locale.%<1> true>

I could have more samples and file separate bug for possible additions
separately.

Thanks,
Takeshi

On 2011年08月25日 11:40, Bart Smaalders wrote:
https://cr.opensolaris.org/action/browse/pkg/barts/transform_files/webrev/

18805 IPS should include sample pkgmogrify transforms for Solaris

http://defect.opensolaris.org/bz/show_bug.cgi?id=18805

Hope to include this in tomorrow's build...

- Bart


_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to