Shawn Walker wrote: > > https://cr.opensolaris.org/action/browse/pkg/dduvall/decddl/ > > src/setup.py: > line 571: why "files == []" instead of "not files" ?
Not sure, other than files really should be a list, but as far as I can tell, we don't actually hit that test, except for /var/cache/pkg/sysrepo, which has an empty dictionary there instead. I've changed it to "if not files". > line 702: is intentional that this sets it to current time/date for > each os.utime op instead of a single date/time determined at the > start of execution? I know we have code that resets the .py files, > but what about other files? Or am I confused? This only ends up installing bits from the zoneproxy directory, so only a few executables and a header file. So there's no need to worry about timestamps as for .py files, and it basically does what install itself does. > lines 901, 904: Might add a comment above these stating they're > required to be implemented by distutils.cmd. Sure. > lines 879: this will fail if you have a new python file you've > created (and may or may not have hg added) but haven't committed yet > when running make install Heh. I ran into that when dorking around with another changeset. Fixed. Thanks, Danek _______________________________________________ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
