Sorry if these questions are stupid, but I don't really understand the
whole colon-escaping thing.  It's a problem when they're contained in
variables?  Is it impossible to do once (say, in the definition of
MANIFESTS or MANIFESTS.cmd) instead for each of MOGRIFESTS, PUBLIFESTS,
and DEPENDED?  Should the same treatment be applied to MANIFESTS, either
on line 58 or 59?

The quoting is because of how make(1) treats colons in separating
targets from dependencies. But your suggestion was a good one and I've
simplified this.

The rest of the changes to the Makefile look fine, if unnecessary.

The primary reason I did this was to try and make webrev's Sdiffs
usable on a monitor for review purposes. That said, there's still one
line of embedded Python in the makefile that I decided to not adjust.

Thanks for the initial review and here's a revised webrev

        
https://cr.opensolaris.org/action/browse/pkg/comay/18888_Revision_1/webrev/
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to