On 10/24/11 15:20, Danek Duvall wrote:
Shawn Walker wrote:
line 113: Do you want to use PKG_DIR_MODE here to os.makedirs to
ensure creation isn't affected by umask, etc. ?
Probably using our own copy of makedirs() is best here?
I specifically didn't suggest that because shutil's copytree relies
on makedirs() raising an error if the target already exists whereas
our makedirs assumes that's ok.
Of course; good point. However, I remembered that I do an explicit chmod()
on dst at the very end of the function, so we should be immune from umask
instrusions.
But could umask cause the initial directory creation to have a
permission that prevents the copying before that to fail?
If not, then ok.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
