On 10/25/11 15:49, Danek Duvall wrote:
Brock Pytlik wrote:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/18990-v1
elfextract.c:
- I would probably get rid of "skip", and when you run into DT_POSFLAG_1,
just increment t.
Good point, I'll try that.
- line 469, 488: space before brace
t_pkgdep.py:
- line 989, 990: Generally the -z options remain in effect for the rest
of the commandline until they're turned off. Thus there's no need to
say
-z deferred -lfoo -z deferred -lbar
because
-z deferred -lfoo -lbar
is equivalent. Since deferred implies lazyload, then you probably
don't need a separate lazy list. Though if you really want to
segregate them, then you probably want to do something like
if deferred_libs:
opts.extend(["-z deferred"] + deferred_libs + ["-z nodeferred"])
(I suppose you needn't even have the conditional if you don't want to
bother with it.)
Ah, didn't realize it worked like that. I do want separate lists for
testing just to make sure.
Thanks for taking a look. I'll send out a new webrev shortly.
Brock
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
