On 11/15/11 19:22, Edward Pilatowicz wrote:
hey all,
i came up with a solver optimization to speed up pkg install if "entire"
(or any other unversioned incorporation) is specified on the command
line. could i get a code review?
http://mcescher.us.oracle.com/export/ws/pkg.instfast/webrev
18987 __trim_recursive_incorps isn't needed when all incorporations are allowed
thanks,
ed
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
pkg_solver.py:
563-578 and 391-407: it seems like commonizing this code might make sense
1256: I think there's an apostrophe missing on "packages"
t_pkg_apI_install:
I think either the new assertRaises should be moved up to pkg5unittest,
or it should be renamed. I'm leaning towards moving it to pkg5unittest
since I can't see any downside using it everyplace we currently use the
stock assertRaises.
Just to double check what I've understood from the bug... This change
shouldn't change either the results from the solver nor the error
messages displayed. It usually makes pkg run faster or the same, but
occasionally can cause pkg to take longer to produce an error message.
Correct? If so, this LGTM.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
